uploader: add options --dry_run and --one_shot #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GalOshri |
davidsoergel
approved these changes
Jun 5, 2020
tensorboard/uploader/uploader.py
Outdated
| @@ -103,6 +104,10 @@ def __init__( | |||
| verbosity: Level of verbosity, an integer. Supported value: | |||
| 0 - No upload statistics is printed. | |||
| 1 - Print upload statistics while uploading data (default). | |||
| one_shot: Once uploading starts, upload only the existing data in and | |||
tensorboard/uploader/flags_parser.py
Outdated
| "--one_shot", | ||
| action="store_true", | ||
| help="Upload only the existing data in the logdir and then exit " | ||
| "immediately, instead of keep listening for new data in the logdir.", |
There was a problem hiding this comment.
...instead of continuing to listen...
| @@ -185,6 +185,45 @@ def testHasNewDataSinceLastSummarizeReturnsTrueAfterNewTensors(self): | |||
| stats.add_blob(blob_bytes=2000, is_skipped=True) | |||
| self.assertEqual(stats.has_new_data_since_last_summarize(), True) | |||
|
|
|||
| def testHasDataInitiallyReturnsFlase(self): | |||
| ) | ||
| self.assertEqual(stats.has_data(), True) | ||
|
|
||
| def testHasDataReturnsTrueWithskippedTensors(self): |
| def CreateExperiment(self, request, **kwargs): | ||
| """Create a new experiment and remember it has been created.""" | ||
| del request, kwargs # Unused. | ||
| return write_service_pb2.CreateExperimentResponse() |
There was a problem hiding this comment.
I'm a little surprised that all the responses can be empty here (except the BlobSequence case, I see). OK, assuming you've tested a dry run with scalar, tensor, and blob data.
There was a problem hiding this comment.
Yep. Manually tested such logdirs with --dry_run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dry_runflag, which when enabled, causes the uploader to only read datafrom the logdir and display the statistics (if
--verboseis the default1) and uploadno data to the server.
DryRunTensorBoardWriterStub.--one_shotflag, which when enabled, causes the uploader to exit immediatelyafter all existing data in the logdir are uploaded.
data.