Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-scalars: fix bug in data download logic and add tests #3794

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

nfelt
Copy link
Contributor

@nfelt nfelt commented Jul 6, 2020

This fixes the custom scalars dashboard so the data download links work again. They have been failing on the backend with the following error due to an argument mismatch from when the experiment support was added:

File ".../python3.7/site-packages/tensorboard/plugins/custom_scalar/custom_scalars_plugin.py", line 126, in download_data_route
    body, mime_type = self.download_data_impl(run, tag, response_format)
TypeError: download_data_impl() missing 1 required positional argument: 'response_format'

To prevent regressions we port the download behavior HTTP-level tests from #3793 to the custom scalars dashboard. Also tested manually by launching tensorboard with test data and confirming the downloads now work as expected.

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@nfelt nfelt merged commit 95a8670 into tensorflow:master Jul 7, 2020
@nfelt nfelt deleted the custom-scalars-download branch July 7, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants