Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebuggerV2] Remove experimental status of plugin #3821

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Jul 9, 2020

  • Motivation for features / changes
    • Remove the requirement to use the experimentalPlugin=debugger-v2 in the
      URL in order to see the Debugger V2 plugin, as discussed offline.
      This is a part of the plan to launch the plugin with tensorflow and tensorboard 2.3.
  • Technical description of changes
    • Remove the ExperimentalPlugin wrapper for the Python class of
      DebuggerV2Plugin in tensorboard/default.py.
  • Screenshots of UI changes
    • When no DebuggerV2 data is found:
      • image
    • When Debugger V2 data is found
      • image
  • Detailed steps to verify changes work correctly (as executed by you)
  • Tested:
    • Manual testing of the Debugger V2 plugin and other common plugins including scalar, graph, and histogram/distribution
    • See screenshots above

@caisq caisq changed the title [DebuggerV2] Remove experimental status of tensorboard plugin [DebuggerV2] Remove experimental status of plugin Jul 9, 2020
@caisq caisq marked this pull request as ready for review July 9, 2020 17:47
@caisq caisq requested a review from stephanwlee July 10, 2020 03:44
Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but could you maybe, in a follow up, improve the v1 plugin's and v2 plugin's landing page and describe when to use what?

Also @GalOshri FYI.

@caisq
Copy link
Contributor Author

caisq commented Jul 13, 2020

The main purpose of this PR is so that users won't have to add the experimentalPlugin=... query string in the URL in order to use Debugger V2. I'm merging this soon unless you have any other thoughts or suggestions.

Improving Debugger V1's landing page sounds good to me. I'll take care of that in a follow-up PR.

@caisq caisq merged commit 3fab9ca into tensorflow:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants