-
Notifications
You must be signed in to change notification settings - Fork 74.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTEL MKL] Refactoring code related to compiling oneDNN with threadpool. #47279
[INTEL MKL] Refactoring code related to compiling oneDNN with threadpool. #47279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cuixiaom Thank you for the heads up!
@agramesh1 Sorry for the delay! I thought this one was not urgent based on the title. I have a few nits.
Co-authored-by: Penporn Koanantakool <[email protected]>
Co-authored-by: Penporn Koanantakool <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and have a great weekend! :)
@penpornk thanks. There was a conflict I resolved just after you approved. Not sure if the changes registered before the testing started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Approving again then. :)
@penpornk thanks for approving again. |
Hi @penpornk The internal Google checks failed for this PR, can you provide the logs for the failures? |
@agramesh1 Thank you for the heads up! I'll fix this internally. |
Refactoring code to replace the macro ENABLE_MKLDNN_THREADPOOL with ENABLE_ONEDNN_OPENMP. Now, the oneDNN based kernels will be compiled to use Eigen threadpool by default unless ENABLE_ONEDNN_OPENMP is defined. PR also includes some minor cleanup to remove unused mkl_opensource build option.