update side effects to fix tree shaking errors #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4248
As a follow-up investigating #4248 revealed that as of October, webpack 5 does not require the sideEffects entry anymore. However I'm not removing it in this PR since i want to (1) investigate how well it (and our other target bundlers do) without that field, and (2) try and get a better sense of how webpack 5 adoption is going. But it does point towards a better future where we won't have to manually maintain that list. I'll make an issue to track removing that.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is