Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ttnn yolov4 with new conv API #10270

Closed
punithsekar opened this issue Jul 15, 2024 · 4 comments
Closed

Implement ttnn yolov4 with new conv API #10270

punithsekar opened this issue Jul 15, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@punithsekar
Copy link
Contributor

punithsekar commented Jul 15, 2024

Implement ttnn yolov4 and demo for yolov4 with new conv API(ttnn.conv2d).

@punithsekar punithsekar added the bug Something isn't working label Jul 15, 2024
@punithsekar
Copy link
Contributor Author

#10068 contains the implementation of ttnn yolov4 with new conv API.
Currently,
In neck sub-module we are using torch max_pool as these configurations are making issues #7746 and we are facing low pcc for two outputs of the neck sub-module(0.94 & 0.96) when we use leakyrelu as activation. If we keep relu then the pcc's are >0.99.

In head sub-module, we are using torch conv in three places as out_channels=255 is not working fine(#10256).

While running yolov4 module we are facing OOM issue in DS5 sub_module first conv itself, But while running DS5 separately works fine.

Also in DS1 to DS5 we are using relu instead mish activation due to following issue in ttnn.mish(#9877).

@punithsekar
Copy link
Contributor Author

punithsekar commented Jul 17, 2024

All the sub-modules and yolov4 model works fine, the YOLOv4 model produces three outputs, and their PCC are greater than 0.95, 0.96, and 0.98, respectively.

Conv issue : 10256
maxpool : 7746
Mish issue : 9877

Currently three fallback conv is used and three maxpool operations are used in the pipeline.

punithsekar added a commit that referenced this issue Jul 18, 2024
punithsekar added a commit that referenced this issue Jul 18, 2024
punithsekar added a commit that referenced this issue Jul 18, 2024
punithsekar added a commit that referenced this issue Jul 18, 2024
@punithsekar
Copy link
Contributor Author

Issue #10256 has been closed,
The latest perf sheets have been updated in the PR #10068.

punithsekar added a commit that referenced this issue Jul 19, 2024
punithsekar added a commit that referenced this issue Jul 22, 2024
punithsekar added a commit that referenced this issue Jul 23, 2024
punithsekar added a commit that referenced this issue Jul 24, 2024
punithsekar added a commit that referenced this issue Jul 25, 2024
punithsekar added a commit that referenced this issue Jul 26, 2024
@keerthana-r-mcw
Copy link
Contributor

Closing this issue, since yolov4 is implemented using new conv-api and merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants