Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8364: Disable implicit fallback for ttnn.reshape #8650

Merged
merged 1 commit into from
May 22, 2024

Conversation

ayerofieiev-tt
Copy link
Member

@ayerofieiev-tt ayerofieiev-tt commented May 20, 2024

What's happening
This is a part of the #8364 effort

ttnn.rehape now do not support automatic/implicit fallback to torch.
Instead, model developers have to explicitly use torch.
Use ttnn.get_fallback_function(ttnn.reshape) for simplicity.

Update

  • Disabled implicit fallback
  • Added ttnn.get_fallback_function to make explicit fallback easier
  • Updated tests and models to call fallback explicitly where needed

CI
Change checked on CI with:

  • Post commit
  • Nightly fast dispatch
  • T3000 frequent tests
  • Model perf regression and output report

There are two remaining failures on CI, which I am ok with:

@ayerofieiev-tt ayerofieiev-tt force-pushed the ay/issue-8364-reshape branch 3 times, most recently from 075f165 to d635adb Compare May 21, 2024 22:02
@ayerofieiev-tt ayerofieiev-tt marked this pull request as ready for review May 22, 2024 05:35
@ayerofieiev-tt ayerofieiev-tt merged commit 276dcfd into main May 22, 2024
5 checks passed
@ayerofieiev-tt ayerofieiev-tt deleted the ay/issue-8364-reshape branch May 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants