-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8364: Disable implicit fallback for ttnn.reshape #8650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
commented
May 20, 2024
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
3 times, most recently
from
May 21, 2024 22:02
075f165
to
d635adb
Compare
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
from
May 21, 2024 22:11
d635adb
to
791635d
Compare
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
from
May 22, 2024 05:23
ff5998f
to
e34f478
Compare
ayerofieiev-tt
requested review from
boris-drazic,
eyonland,
cfjchu and
xanderchin
as code owners
May 22, 2024 05:35
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
from
May 22, 2024 05:36
e34f478
to
49e6635
Compare
arakhmati
approved these changes
May 22, 2024
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
from
May 22, 2024 05:49
49e6635
to
5d256fa
Compare
ayerofieiev-tt
force-pushed
the
ay/issue-8364-reshape
branch
from
May 22, 2024 13:30
5d256fa
to
f2a043a
Compare
boris-drazic
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening
This is a part of the #8364 effort
ttnn.rehape
now do not support automatic/implicit fallback totorch
.Instead, model developers have to explicitly use torch.
Use
ttnn.get_fallback_function(ttnn.reshape)
for simplicity.Update
CI
Change checked on CI with:
There are two remaining failures on CI, which I am ok with: