-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic tlb config from constructor #131
Conversation
445a48c
to
14a5cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Might be worth creating a Metal branch, updating its UMD submodule, fixing up whatever breaks (somewhere Metal must be constructing a tt_SiliconDevice
) and then running Metal CI.
The ideal way would be making two-phase changes for each API change that we make. That means, implement the new api while keeping old functional. Then change tt-metal usage to new api. Then delete the old api here. All this said, please do create an experimental tt-metal branch and verify everything will remain functional after this change before merging this. |
14a5cf5
to
39f5613
Compare
Builds with tt-metal, merging... |
Bumping UMD to newest version. dynamic_tlb_config was removed from constructor. Related UMD PR: tenstorrent/tt-umd#131
Remove
dynamic_tlb_config
map fromtt_SiliconDevice
constructor.Part of the larger effort #118. This is just removing one of the problems that we are facing with tt_SiliconDevice constructor.