Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic tlb config from constructor #131

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

pjanevskiTT
Copy link
Contributor

Remove dynamic_tlb_config map from tt_SiliconDevice constructor.

Part of the larger effort #118. This is just removing one of the problems that we are facing with tt_SiliconDevice constructor.

@pjanevskiTT pjanevskiTT self-assigned this Oct 8, 2024
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/silicon_driver_constructor branch 2 times, most recently from 445a48c to 14a5cf5 Compare October 8, 2024 14:03
Copy link
Contributor

@joelsmithTT joelsmithTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Might be worth creating a Metal branch, updating its UMD submodule, fixing up whatever breaks (somewhere Metal must be constructing a tt_SiliconDevice) and then running Metal CI.

@broskoTT broskoTT linked an issue Oct 9, 2024 that may be closed by this pull request
@broskoTT
Copy link
Contributor

broskoTT commented Oct 9, 2024

Might be worth creating a Metal branch, updating its UMD submodule, fixing up whatever breaks (somewhere Metal must be constructing a tt_SiliconDevice) and then running Metal CI.

The ideal way would be making two-phase changes for each API change that we make. That means, implement the new api while keeping old functional. Then change tt-metal usage to new api. Then delete the old api here.
That way we don't block other improvements in UMD from being merged into metal. However, this only solves problems if we have a high throughput of code changes in UMD, but since we don't, this might be fine.

All this said, please do create an experimental tt-metal branch and verify everything will remain functional after this change before merging this.

@pjanevskiTT pjanevskiTT force-pushed the pjanevski/silicon_driver_constructor branch from 14a5cf5 to 39f5613 Compare October 17, 2024 15:06
@pjanevskiTT
Copy link
Contributor Author

pjanevskiTT commented Oct 17, 2024

Builds with tt-metal, merging...

@pjanevskiTT pjanevskiTT merged commit cb82f33 into main Oct 17, 2024
16 checks passed
@pjanevskiTT pjanevskiTT deleted the pjanevski/silicon_driver_constructor branch October 17, 2024 15:45
@broskoTT broskoTT added the changes api API changing PR, needs changes in client code label Oct 18, 2024
broskoTT added a commit to tenstorrent/tt-metal that referenced this pull request Oct 22, 2024
Bumping UMD to newest version.
dynamic_tlb_config was removed from constructor. Related UMD PR: tenstorrent/tt-umd#131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes api API changing PR, needs changes in client code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink tt_SiliconDevice construction
3 participants