Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out SIGSYS handling and redirect accept to accept4 #11

Merged
merged 1 commit into from
Mar 10, 2018

Conversation

marksteward
Copy link
Contributor

@marksteward marksteward commented Mar 8, 2018

This fixes SIGSYS on Oreo for processes that call accept. I can't see a recent change to bionic, but accept4 definitely seems to be the supported call.

I'm not massively familiar with this codebase, and I've basically pulled out the code from 454b0b1 and chain.c. It took a while to work out something that does the right thing, so it's likely I've misunderstood how it should work or overlooked a corner case.

Tested on aarch64, Android 8.0.0, kernel 3.18.66-perf targetting nc -l -p 8080 and chromium-browser --headless on Ubuntu.

@marksteward
Copy link
Contributor Author

On a side note, I've been building and testing this on termux, and it seems that the clang toolchain includes some changes that break the build process. Should I create a PR to fix that?

@michalbednarski
Copy link
Collaborator

Thanks, I'll test this myself and merge then

If build doesn't work for you and/or you've made changes that allow it to be built on something else than what I'm using/be built on device, that pull request is are also welcome.

I'm usually building this through termux-packages and then install .deb on device. For development (when not using version pushed to git repo) appending following to packages/proot/build.sh can be used to build local version:

termux_step_extract_package () {
	cp -r /home/.../proot $TERMUX_PKG_SRCDIR
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants