Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgc: Update to 8.2.2 #11910

Merged
merged 1 commit into from
Sep 19, 2022
Merged

libgc: Update to 8.2.2 #11910

merged 1 commit into from
Sep 19, 2022

Conversation

ivmai
Copy link
Contributor

@ivmai ivmai commented Sep 13, 2022

  • Fix license (the package is covered by MIT-style license, not GPL)
  • Drop include-private-gcconfig.h.patch (should not be needed any more)
  • Remove dependency on libatomic_ops (libgc uses gcc built-in atomics)

@ivmai ivmai mentioned this pull request Sep 13, 2022
Closed
@ravener
Copy link
Contributor

ravener commented Sep 13, 2022

Remove dependency on libatomic_ops (libgc uses gcc built-in atomics)

Termux does not use gcc though, it uses clang from the Android NDK.

@ivmai
Copy link
Contributor Author

ivmai commented Sep 13, 2022

Termux does not use gcc though, it uses clang from the Android NDK.

clang is compliant with gcc regarding atomic intrinsic.

@ravener
Copy link
Contributor

ravener commented Sep 13, 2022

Well somehow the CI logs says that the build failed because libatomic_ops is required.

@ivmai
Copy link
Contributor Author

ivmai commented Sep 13, 2022

checking for compiler intrinsics support... skipped because cross-compiling

I'll fix it by passing --with-libatomic-ops=none to configure

@ivmai ivmai force-pushed the update-libgc-8_2_2 branch 2 times, most recently from 5eb8e58 to e4c6872 Compare September 13, 2022 08:49
@ivmai
Copy link
Contributor Author

ivmai commented Sep 13, 2022

@ravener How to pass an extra flag to configure correctly?

@2096779623
Copy link
Member

@ravener How to pass an extra flag to configure correctly?

If you need to pass some additional arguments, use the field TERMUX_PKG_EXTRA_CONFIGURE_ARGS .

https://github.com/termux/termux-packages/wiki/Creating-new-package

@2096779623
Copy link
Member

2096779623 commented Sep 13, 2022 •
edited
Loading

Try add TERMUX_PKG_LICENSE_FILE="../../../LICENSE" to install LICENSE file.

Edit: Maybe TERMUX_PKG_BUILD_IN_SRC=true is more suitable.

@ivmai ivmai force-pushed the update-libgc-8_2_2 branch 2 times, most recently from aae5d31 to 7a02c5a Compare September 13, 2022 09:30
@ivmai
Copy link
Contributor Author

ivmai commented Sep 13, 2022

Try add TERMUX_PKG_LICENSE_FILE="../../../LICENSE" to install LICENSE file.

Edit: Maybe TERMUX_PKG_BUILD_IN_SRC=true is more suitable.

I've decided finally to install README.QUICK which lists the license.

finagolfin
finagolfin reviewed Sep 13, 2022
View reviewed changes
packages/libgc/build.sh Outdated Show resolved Hide resolved
@ivmai
libgc: Update to 8.2.2
2bb7453 
* Fix license (the package is covered by MIT-style license, not GPL)
* Install README.QUICK as a license file
* Drop include-private-gcconfig.h.patch (should not be needed any more)
* Remove dependency on libatomic_ops (libgc uses gcc built-in atomics)
@ivmai ivmai requested review from finagolfin and removed request for Grimler91, landfillbaby and 2096779623 September 16, 2022 20:37
@ivmai
Copy link
Contributor Author

ivmai commented Sep 19, 2022

@ravener, @2096779623 Anything else to change?

@finagolfin finagolfin merged commit 76cb1a8 into termux:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finagolfin finagolfin finagolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivmai @ravener @2096779623 @finagolfin