Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main/seanime): web-ui issue #21494

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix(main/seanime): web-ui issue #21494

merged 1 commit into from
Sep 29, 2024

Conversation

aicynide
Copy link
Contributor

closes: #21458

aicynide
aicynide commented Sep 16, 2024
View reviewed changes
packages/seanime/build.sh
@@ -20,7 +20,6 @@ termux_step_host_build() {
}

termux_step_pre_configure() {
mkdir $TERMUX_PKG_SRCDIR/web
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mkdir $TERMUX_PKG_SRCDIR/web then no issue to copy all files ** instead it'll copy whole folder

@aicynide
Copy link
Contributor Author 

curl -Ls https://nightly.link/termux/termux-packages/actions/runs/10891339607/debs-aarch64-c0cd1324f2846edce0bed000b0d8694527e01a08.zip -o seanime.zip
unzip seanime.zip
tar -xvf debs-*
dpkg -i debs/seanime*

@aicynide
Copy link
Contributor Author

@5rahim don't be mad but removing the line mkdir $TERMUX_PKG_SRCDIR/web actually fixed the issue and you were also not wrong

I tested the .deb and seanime is working fine in Android now

licy183
licy183 requested changes Sep 20, 2024
View reviewed changes
packages/seanime/build.sh
@@ -20,7 +20,6 @@ termux_step_host_build() {
}

termux_step_pre_configure() {
mkdir $TERMUX_PKG_SRCDIR/web
cp -r $TERMUX_PKG_HOSTBUILD_DIR/seanime-web/out $TERMUX_PKG_SRCDIR/web/
Copy link
Member

@licy183 licy183 Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -r $TERMUX_PKG_HOSTBUILD_DIR/seanime-web/out $TERMUX_PKG_SRCDIR/web/
mkdir -p $TERMUX_PKG_SRCDIR/web
cp -r $TERMUX_PKG_HOSTBUILD_DIR/seanime-web/out/* $TERMUX_PKG_SRCDIR/web/

@licy183
Copy link
Member

licy183 commented Sep 29, 2024

I'll merge this now.

@licy183 licy183 merged commit f59246a into termux:master Sep 29, 2024
7 checks passed
nguynkhn pushed a commit to nguynkhn/termux-packages that referenced this pull request Oct 16, 2024
@aicynide @nguynkhn
fix(main/seanime): web-ui issue (termux#21494)
4cf97d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licy183 licy183 licy183 requested changes

@finagolfin finagolfin Awaiting requested review from finagolfin

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: seanime: Client error error="Cannot GET /index.html"
2 participants
@aicynide @licy183