Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Bump to 1.56.0 #7790

Merged
merged 1 commit into from
Oct 24, 2021
Merged

rust: Bump to 1.56.0 #7790

merged 1 commit into from
Oct 24, 2021

Conversation

thunder-coding
Copy link
Member

Rust has some build errors as in #7339 (comment)

Lets fix this

@thunder-coding thunder-coding marked this pull request as draft October 23, 2021 01:36
@thunder-coding
Copy link
Member Author

thunder-coding commented Oct 23, 2021

It is currently building libllvm, will wait for @buttaface to bump libllvm after NDK update and then continue this PR

Waiting for #7627 to get in

@finagolfin
Copy link
Member

Yes, once #7627 is in, we can build this, should take 5-6 hours for libllvm to get in.

@finagolfin
Copy link
Member

There was some issue with uploading the LLVM 13 packages from the CI, @Grimler91, will someone have to do it manually?

@Grimler91
Copy link
Member

I have uploaded them, will be available next time repo is re-signed (when 022378b is uploaded probably)

@thunder-coding thunder-coding marked this pull request as ready for review October 24, 2021 11:56
@thunder-coding
Copy link
Member Author

Rust has finally compiled. Interested users can help by downloading the debs from artifacts and reporting issues here (if any).

Finally it built !

@thunder-coding
Copy link
Member Author

The rust deb seems to be empty

$ dpkg -c rust_1.56.0_aarch64.deb | grep /bin/ | termux-clipboard-set
drwx------ builder/builder        0 2021-10-24 17:15 ./data/data/com.termux/files/usr/bin/
lrwxrwxrwx builder/builder        0 2021-10-24 17:15 ./data/data/com.termux/files/usr/bin/rust-lld -> /data/data/com.termux/files/usr/bin/lld

@Grimler91
Copy link
Member

@thunder-coding nice work!

@Grimler91 Grimler91 merged commit 861be43 into termux:master Oct 24, 2021
@thunder-coding
Copy link
Member Author

@thunder-coding nice work!

You seem to have missed my earlier comment. The debs don't have rustc, cargo and other binaries 🙃

@Grimler91
Copy link
Member

Grimler91 commented Oct 24, 2021

Well, darn, it at least seem to have gotten further before erroring out with:

note: ld: error: /data/data/com.termux/files/usr/lib/libz.so is incompatible with elf64-x86-64

This is for stage1-tools, which I guess should be host-built, so it seems that issue is that -L/data/data/com.termux/files/usr/lib is added to flags

@thunder-coding
Copy link
Member Author

Well, darn, it at least seem to have gotten further before erroring out with:\n\nnote: ld: error: /data

I wonder why it didn't error out and exit with non-zero exit code. Something's fishy on Rust's side, should report this to upstream

@Grimler91
Copy link
Member

Rust seem to automatically drop to a shell on error, to make it easier to debug for developers I guess, but it obviously cases issues for automatic builds. Maybe it is possible to turn this off somehow

@thunder-coding
Copy link
Member Author

thunder-coding commented Oct 24, 2021

Nah, it seems like only x86_64 has those binaries. I doubted this because artifacts were largest for x86_64. I checked and found that cargo, rustc and other binaries were available for x86_64.

This means most probably we need to perform

if [ $TERMUX_ARCH = "x86_64" ]; then
and
if [ $TERMUX_ARCH = "x86_64" ]; then
also for other archs too if I am not wrong

@buttaface Any ideas?

@shadmansaleh
Copy link
Contributor

shadmansaleh commented Oct 24, 2021

Hay on rust I'd like to ask something . Rust library sources are shipped with the package right ?

When steping through rust code in debugger it tries to jump to those sources but fail . Because they try to jump to location on build system path and termux has the sources in the different path . Can something be done about that ?

Edit: lol I thought the bump suceeded and I restarted #7547 😆

@finagolfin
Copy link
Member

No, I think @its-pointless usually dealt with this package, I didn't do much with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants