fix tally to correctly collect ballot losers

terra-money · Oct 14, 2019 · ce700f2 · ce700f2
1 parent 87ec62a
commit ce700f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/x/oracle/abci.go b/x/oracle/abci.go
@@ -33,7 +33,7 @@ func EndBlocker(ctx sdk.Context, k Keeper) {
 		return false
 	})
 
-	// Transit whitelist array to map for fast lookup
+	// Changes whitelist array to map for fast lookup
 	whitelistMap := make(map[string]bool)
 	for _, denom := range k.Whitelist(ctx) {
 		whitelistMap[denom] = true

diff --git a/x/oracle/tally.go b/x/oracle/tally.go
@@ -23,8 +23,9 @@ func tally(ctx sdk.Context, pb types.PriceBallot, k Keeper) (weightedMedian sdk.
 	}
 
 	for _, vote := range pb {
-		if vote.Price.GTE(weightedMedian.Sub(rewardSpread)) && vote.Price.LTE(weightedMedian.Add(rewardSpread)) {
-			if validator := k.StakingKeeper.Validator(ctx, vote.Voter); validator != nil {
+		// If a validator is not found, then just ignore the vote
+		if validator := k.StakingKeeper.Validator(ctx, vote.Voter); validator != nil {
+			if vote.Price.GTE(weightedMedian.Sub(rewardSpread)) && vote.Price.LTE(weightedMedian.Add(rewardSpread)) {
 				power := validator.GetConsensusPower()
 
 				ballotWinners = append(ballotWinners, types.Claim{