Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] oracle reward band is too tight #280

Closed
yun-yeo opened this issue Nov 20, 2019 · 0 comments · Fixed by #281
Closed

[BUG] oracle reward band is too tight #280

yun-yeo opened this issue Nov 20, 2019 · 0 comments · Fixed by #281
Assignees
@yun-yeo
Labels
bug Something isn't working

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Nov 20, 2019

Describe the bug
At oracle tally, the reward band is ratio but it is applied by addition operation. Due to this bug, it just allow 0.1 exchange rate error.

To Reproduce
Do oracle vote with different exchange-rates more than 0.1.

Context & versions
v0.3.0-rc1

(if applicable) suggested solution
Change addition operation to multiplication
@yun-yeo yun-yeo added the bug Something isn't working label Nov 20, 2019
@yun-yeo yun-yeo self-assigned this Nov 20, 2019
@yun-yeo yun-yeo mentioned this issue Nov 20, 2019
Merged
8 tasks
tuky191 pushed a commit that referenced this issue Sep 12, 2023
@dependabot
build(deps): Bump actions/setup-go from 3 to 4 (#280)
d4c8a69 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yun-yeo yun-yeo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] fix to apply reward spread by multiplication terra-money/classic-core
1 participant
@yun-yeo