Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/repository language #203

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Bugfix/repository language #203

merged 5 commits into from
Jul 8, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jul 8, 2019

** Summary of changes **

Add gitattributes to prevent linguist from checking vendor code and documentations. This will make the main language of the core repository Golang on github.

solve #194

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the bug Something isn't working label Jul 8, 2019
@yun-yeo yun-yeo requested review from hanjukim and dokwon July 8, 2019 09:31
dokwon
dokwon approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will revert if the merged changes dont change the repo language

@dokwon dokwon merged commit bb7dbec into develop Jul 8, 2019
@dokwon dokwon deleted the bugfix/repository-language branch July 8, 2019 11:41
@yun-yeo yun-yeo mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

@hanjukim hanjukim Awaiting requested review from hanjukim

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @dokwon