Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runsim update #232

Merged
merged 1 commit into from
Sep 23, 2019
Merged

runsim update #232

merged 1 commit into from
Sep 23, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 17, 2019

Summary of changes

Update runsim interface

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon September 17, 2019 10:47
dokwon
dokwon approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit f24c6cb into develop Sep 23, 2019
@dokwon dokwon deleted the feature/runsim-update branch September 23, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @dokwon