Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cleanup" #115

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Revert "Cleanup" #115

merged 1 commit into from
Mar 21, 2023

Conversation

emidev98
Copy link
Contributor

Hello Team,

Thanks @faddat for submitting the #98 and @gregnuj for reviewing the PR. Unfortunately we have to revert the PR since this other PR #106 contains a major upgrade on core.

The #106 already contains the fixes for the linter and some of the files that were modified aren't existing anymore (app/ante/ante_test.go, app/ante/sigverify.go and app/tx/broadcast.go
). But please feel free to keep contributing any help is very welcome.

Reverts #98

This reverts commit a97277b.
@emidev98 emidev98 marked this pull request as ready for review March 21, 2023 07:33
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #115 (a5056d6) into main (a97277b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   73.64%   73.64%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          489      489           
  Misses        149      149           
  Partials       26       26           
Impacted Files Coverage Δ
app/ante/sigverify.go 73.68% <ø> (ø)
app/app.go 89.76% <ø> (ø)
app/export.go 37.64% <ø> (ø)

@gregnuj gregnuj merged commit 4e583cc into main Mar 21, 2023
@gregnuj gregnuj deleted the revert-98-linting branch March 21, 2023 15:48
gregnuj added a commit that referenced this pull request Mar 28, 2023
…tory, cosmos v0.46) (#106)

* Cleanup (#98)

* golangci-lint run ./... --fix

* gofumpt

* cleaner linter config

* remove init.go

* Update/readme (#110)

* Create banner.png

* Update readme.md

* Delete banner.png

* Create CODE_OF_CONDUCT.md

* Update readme.md

* fix: swagger gen

* Revert "Cleanup (#98)" (#115)

This reverts commit a97277b.

* feat: update swagger gen

---------

Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Evan <[email protected]>
Co-authored-by: emidev98 <[email protected]>
Co-authored-by: emidev98 <[email protected]>
Co-authored-by: Greg Junge <[email protected]>
gregnuj added a commit that referenced this pull request Apr 20, 2023
* upgraded to use cosmos-sdk 46

* feat: added token factory

* feat: added ibc wasm hooks

* feat: added healthcheck route

* fix: renamed rest to error

* fix: comsos-sdk/46 imports

* feat: cosmossdk-46 add ICA

* feat: added token factory genesis

* feat: refactored upgrades and added tokenfactory genesis

* refactored terra app configs

* fix: added tokenfactory to app init

* feat: remove icagenesis from InitChainer

* feat: enable ica

* feat: ICA demo and instructions to run the demo

* fix: added test script to test chain upgrade + fixes for stores

* fix: lint issues

* fix: added ibc fee module

* fix: make sure chain upgrade tester runs for the current codebase

* feat: add alliance

* fix: updated github workflows and added go.mod

* fix: moved alliance keeper up

* feat: added alliance and token factory swagger

* feat: added ica host and controller swagger

* chore: update chain upgrade tester

* feat: intechain acc test all in one

* feat: restructure integration tests

* feat: integration tests ibc-hooks

* feat: integration tests with ibc-hooks

* feat: integration tests for alliance

* fix: typos for progoc gen

* feat: integration tests for versting accounts

* feat: waiting for alliance to be instantiated

* feat: integration tests for token factoryg

* feat: spendable balance caclculated by block

* chore: update cosmos sdk

* feat: validate the custom bank module integration

* fix: ci on cosmossdk 46

* fix: tests for vesting accounts

* removed dependency on cometbft-db

* chore: dependencies

* fix: golang version ci

* feat: upgrade ci from v3 to v4

* feat: add cosmwasm_1_1

* tests: added chain simulation

* updated cosmos-sdk

* added simulate into CI

* test: add unit tests for simulation

* fix:Gosec Security Scanner

* test: alliance integration tests params

* fix: swagger gen (#116)

* add release

* reup of release,dockerfile,makefile

* add readme/cc frommain

* fix error in readme

* add multiplatform builds

* remove darwin from  multiplatform builds

* update release build

* update makefile

* uncomment version for binary build

* create rls thru github cli

* set gh_token env variable

* change draft to prerelease

* change darwin to linux for mac build

* change darwin to linux for mac build

* create release then upload artifacts

* add github token to release action

* fix checkout in release job

* calculate rls hashes thru github action

* calculate checksum

* calculate checksum

* calculate checksum

* calculate checksum

* use --repo switch instead cloning

* Major upgrade to core (Alliance, IBC-hooks, ICA controller, token factory, cosmos v0.46) (#106)

* Cleanup (#98)

* golangci-lint run ./... --fix

* gofumpt

* cleaner linter config

* remove init.go

* Update/readme (#110)

* Create banner.png

* Update readme.md

* Delete banner.png

* Create CODE_OF_CONDUCT.md

* Update readme.md

* fix: swagger gen

* Revert "Cleanup (#98)" (#115)

This reverts commit a97277b.

* feat: update swagger gen

---------

Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Evan <[email protected]>
Co-authored-by: emidev98 <[email protected]>
Co-authored-by: emidev98 <[email protected]>
Co-authored-by: Greg Junge <[email protected]>

* Update markdown files (#123)

* Update readme.md

* Update CHANGELOG.md

* Update RELEASES.md

* Update SECURITY.md

* Update README.md

* Update README.md

* fix: security wasmvm (#122)

* fix: security wasmvm

* add dokerfile updates

* update wasmd

* update ledger-go dep

* chore: increase code version

---------

Co-authored-by: gregnuj <[email protected]>

* Release/v2.3 (#127)

* fix: security wasmvm

* add dokerfile updates

* update wasmd

* update ledger-go dep

* Update markdown files (#123) (#124)

* Update readme.md

* Update CHANGELOG.md

* Update RELEASES.md

* Update SECURITY.md

* Update README.md

* Update README.md

Co-authored-by: Evan <[email protected]>

* Test (#126)

* Update markdown files (#123)

* Update readme.md

* Update CHANGELOG.md

* Update RELEASES.md

* Update SECURITY.md

* Update README.md

* Update README.md

* fix: security wasmvm (#122)

* fix: security wasmvm

* add dokerfile updates

* update wasmd

* update ledger-go dep

* chore: increase code version

---------

Co-authored-by: gregnuj <[email protected]>
Co-authored-by: Evan <[email protected]>
Co-authored-by: emidev98 <[email protected]>

* fix: coverage report

---------

Co-authored-by: javiersuweijie <[email protected]>
Co-authored-by: javier <[email protected]>
Co-authored-by: gregnuj <[email protected]>
Co-authored-by: Michal Turcan <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Evan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants