Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation records when wildcard is present with alternative d… #32

Merged

Conversation

mmiranda
Copy link
Contributor

…omains

Description

This PR address changes related to Issue #27.

Creates validation records for all SANs with wildcard

@mmiranda
Copy link
Contributor Author

@antonbabenko any chance to get this merged?

@antonbabenko antonbabenko merged commit 43a87c2 into terraform-aws-modules:master Dec 19, 2019
@antonbabenko
Copy link
Member

Thanks @mmiranda for this fix!

This PR has fixed issue #27.

v2.5.0 of this module has been just released.

@mignaulo
Copy link

Apologies for commenting on an already merged PR - Could someone explain why length(local.distinct_domain_names) + 1 (specifically the + 1) is required here? It always seems to wraparound the list and create the first element twice.

module.deploy-certificate.aws_route53_record.validation[2]: Creation complete after 36s [id=XXXXXXXX__4646f770db759d1fb15a85334855c.deploy.example.com._CNAME]
module.deploy-certificate.aws_route53_record.validation[1]: Creation complete after 37s [id=XXXXXXXX__5a3e97a89c32db71bf862e73e50a3.deploy.internal.example.com._CNAME]
module.deploy-certificate.aws_route53_record.validation[0]: Creation complete after 37s [id=XXXXXXXX__46456770db759d1fb15a85334855c.deploy.example.com._CNAME]

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants