Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for disabling connection termination for unhealthy targets and AZ DNS affinity #315

Merged

Conversation

magreenbaum
Copy link
Member

Description

Add dns_record_client_routing_policy to aws_lb and target_health_state to aws_lb_target_group.

Motivation and Context

hashicorp/terraform-provider-aws#34070
hashicorp/terraform-provider-aws#33992

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title feat: Additional arguments for nlb feat: Add support for disabling connection termination for unhealthy targets and AZ DNS affinity Oct 30, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit c79324e into terraform-aws-modules:master Oct 30, 2023
9 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 30, 2023
## [9.1.0](v9.0.0...v9.1.0) (2023-10-30)

### Features

* Add support for disabling connection termination for unhealthy targets and AZ DNS affinity ([#315](#315)) ([c79324e](c79324e))
@antonbabenko
Copy link
Member

This PR is included in version 9.1.0 🎉

@magreenbaum magreenbaum deleted the feat/nlb_arguments branch November 2, 2023 12:37
Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants