Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: atlantis health check path #242

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix: atlantis health check path #242

merged 1 commit into from
Dec 6, 2021

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Dec 3, 2021 •
edited
Loading

Description

Update health check path for Atlantis.

Motivation and Context

Atlantis has the /healthz endpoint for health checks. This endpoint should be used for health checks from ALB.

For example, if Atlantis BASIC authentication is enabled, this endpoint is the only path that does not require authentication.

Breaking Changes

No.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@antonbabenko antonbabenko merged commit 0b17a41 into terraform-aws-modules:master Dec 6, 2021
antonbabenko pushed a commit that referenced this pull request Dec 6, 2021
@semantic-release-bot
chore(release): version 3.5.3 [skip ci]
167af83 
## [3.5.3](v3.5.2...v3.5.3) (2021-12-06)

### Bug Fixes

* atlantis health check path ([#242](#242)) ([0b17a41](0b17a41))
* ensure pre-commit is using latest version via HTTPS ([#240](#240)) ([57935f0](57935f0))
@antonbabenko
Copy link
Member

This PR is included in version 3.5.3 🎉

@chroju chroju deleted the mod_health_check_path branch December 6, 2021 23:07
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chroju @antonbabenko