Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for booleans should be false so they do not show up as required in Terraform Registry #368

Conversation

robin-norwood
Copy link

…required in Terraform registry

Description

Before this change, several values show up as "required" that probably should not be:

Screenshot_2019-12-05 terraform-aws-modules vpc aws Terraform Registry

@robin-norwood robin-norwood changed the title Default value for booleans should be false so they do not show up as … Default value for booleans should be false so they do not show up as required in Terraform Registry Mar 16, 2020
@antonbabenko
Copy link
Member

Hi @robin-norwood !

Thanks for opening this issue here but I think this problem has to be fixed in Terraform Registry and Terraform Cloud where null values are not respected properly. There is an open issue already - hashicorp/terraform#21417

There is nothing that we should do in this module.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants