Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlserver failed TF samples is blocking other PRs #549

Closed
msampathkumar opened this issue Dec 6, 2023 · 1 comment
Closed

sqlserver failed TF samples is blocking other PRs #549

msampathkumar opened this issue Dec 6, 2023 · 1 comment
Assignees
@msampathkumar

Comments

@msampathkumar
Copy link
Contributor 

          > Hi @msampathkumar, thanks for reviewing the change. I saw the above `terraform-docs-samples-int-trigger (cloud-foundation-cicd)` failed with `--- FAIL: TestSamples/2/sqlserver_instance_private_ip (603.18s)`. I feel my change should not impact it. Please advice. Thanks.

Sorry for the trouble. The CICD is the process of being upgraded and we would have wait for it be completed or this bug to cleared up.

Originally posted by @msampathkumar in #538 (comment)
@msampathkumar msampathkumar self-assigned this Dec 6, 2023
@msampathkumar
Copy link
Contributor Author

msampathkumar commented Dec 6, 2023 •
edited
Loading

Update:

When tested, the samples seem be working fine. Said that, it took long time for the samples to deploy(~5 mins). During the deletion found a bug: hashicorp/terraform-provider-google#16275

This was referenced Dec 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msampathkumar msampathkumar

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@msampathkumar