-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampathm path 1 #551
Closed
msampathkumar
wants to merge
15
commits into
terraform-google-modules:main
from
msampathkumar:sampathm-path-1
Closed
Sampathm path 1 #551
msampathkumar
wants to merge
15
commits into
terraform-google-modules:main
from
msampathkumar:sampathm-path-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
…ion-policy (terraform-google-modules#500) * Prepared main.tf for inclusion in C.G.C. documentation * Updated service class * Minor edits to main.tf * Added networkconnectivity API to test setup file * Remove description, remove 'my' from policy name Co-authored-by: Sampath Kumar <[email protected]> * Update product prefix to networkconnectivitycenter --------- Co-authored-by: Scott Kratochvil <[email protected]> Co-authored-by: Sampath Kumar <[email protected]> Co-authored-by: Sampath Kumar <[email protected]> Co-authored-by: Eric Dong <[email protected]>
…gle-modules#514) * fix: add directory prune to int build config * exclude test/ * also prune from lint test * nevermind lint * Update build/int.cloudbuild.yaml Co-authored-by: Sampath Kumar <[email protected]> * whitespace * don't use _HEAD_BRANCH in diff * a test change * undo test change --------- Co-authored-by: Sampath Kumar <[email protected]>
…ogle-modules#511) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sampath Kumar <[email protected]>
Co-authored-by: Sampath Kumar <[email protected]>
* update: object table docs * update: fix comment, resource name * update: integrate reviewer feedback * update: integrate reviewer input --------- Co-authored-by: Roger Martinez <[email protected]> Co-authored-by: Sampath Kumar <[email protected]>
Co-authored-by: Roger Martinez <[email protected]>
…erraform-google-modules#516) * retreive run service data * run service iam * correct names * don't use data block
1. Takes too long 2. Temporary Issues with Terraform resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #549
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness