Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampathm path 1 #551

Conversation

msampathkumar
Copy link
Contributor

Description

Fixes: #549

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

msampathkumar and others added 15 commits October 5, 2023 12:25
 Please enter the commit message for your changes. Lines starting
…ion-policy (terraform-google-modules#500)

* Prepared main.tf for inclusion in C.G.C. documentation

* Updated service class

* Minor edits to main.tf

* Added networkconnectivity API to test setup file

* Remove description, remove 'my' from policy name

Co-authored-by: Sampath Kumar <[email protected]>

* Update product prefix to networkconnectivitycenter

---------

Co-authored-by: Scott Kratochvil <[email protected]>
Co-authored-by: Sampath Kumar <[email protected]>
Co-authored-by: Sampath Kumar <[email protected]>
Co-authored-by: Eric Dong <[email protected]>
…gle-modules#514)

* fix: add directory prune to int build config

* exclude test/

* also prune from lint test

* nevermind lint

* Update build/int.cloudbuild.yaml

Co-authored-by: Sampath Kumar <[email protected]>

* whitespace

* don't use _HEAD_BRANCH in diff

* a test change

* undo test change

---------

Co-authored-by: Sampath Kumar <[email protected]>
…ogle-modules#511)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sampath Kumar <[email protected]>
* update: object table docs

* update: fix comment, resource name

* update: integrate reviewer feedback

* update: integrate reviewer input

---------

Co-authored-by: Roger Martinez <[email protected]>
Co-authored-by: Sampath Kumar <[email protected]>
…erraform-google-modules#516)

* retreive run service data

* run service iam

* correct names

* don't use data block
1. Takes too long
2. Temporary Issues with Terraform resource
@msampathkumar msampathkumar requested review from a team as code owners December 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlserver failed TF samples is blocking other PRs
4 participants