feat: Adding examples for integrationconnectors endpointattachment and managed zone

[balanaguharsha]

Adding examples for integrationconnectors endpointattachment and managed zone

Description

Fixes b/374649808

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

• Yes, merge this PR after it is approved
• No, don't merge this PR after it is approved

Style

• My sample follows the rules described for Terraform in the Effective Samples style guide
• My sample follows the other requirements and best practices in the Contributing
  guide

Testing

• I have performed tests described in the Contributing guide:

  • Tests pass: terraform apply
  • Lint pass: terraform fmt check

Intended location

• [YES] Yes, this sample will be (or already is) included on cloud.google.com
  Location(s):https://cloud.google.com/integration-connectors/docs/sample-terraform-template

• No, this sample won't be included on cloud.google.com
  Reason:

API enablement

• If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

• If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[snippet-bot]

Here is the summary of changes.

You are about to add 1 region tag.

• integrationconnectors/managedzone/main.tf:47, tag integrationconnectors_managed_zone_example

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[balanaguharsha]

Please issue /gcbrun

[balanaguharsha]

/gcbrun

[glasnt]

/gcbrun

[glasnt]

The first error these samples encountered (for managed zone):

 Error 400: Service account [email protected] does not exist., badRequest
        	            	
        with google_project_iam_member.default,
        on main.tf line 20, in resource "google_project_iam_member" "default":
        20: resource "google_project_iam_member" "default" {
}

Is it expected that this service account is created when the connectors.googleapis.com API is enabled? Could you instead use a custom service account?

Also checking if these code samples are valid (given you're trying to setup DNS for example.com, I'm not sure if this is something that should be provisionable). If it's not, please provide a test.yaml configured to skip tests.

I'll add comments for code review onto the code itself.

[glasnt]

/gcbrun

[glasnt]

This sample needs a region tag.

[glasnt]

If you want to have two data.google_project, one needs to have a project_id, otherwise you use the provider's google project (the active project). https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/project

I would suggest adding a comment of the config to help show what you mean (and have a comment if the "test_project" is the "current" project

[glasnt]

This is the only region tag in this sample; is this intended? Do you want the other resources to be shown in the docs? If so, they also need region tags.