Preconditions Script Checks Billing Account Format #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json.dump accepts file object as second argument and writes to it. There's no need to call `print` since it's writing to stdout.
This will make the program fail faster should an obviously incorrect value be passed as the billing account.
trotttrotttrott
changed the title
aaron-lane
previously approved these changes
Jan 18, 2019
|
@morgante I believe this is ready to merge. I just resolved a conflict with master. Doing so dismissed @aaron-lane's review, however, the changes that were previously approved are the same. |
adrienthebo
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preconditions script checks that billing account is in the correct format. This will make the program fail faster should an obviously incorrect value be passed as the billing account.
In addition, this changes the
json.dumpscall tojson.dumpin themainmethod. This was failing with aTypeErrorsince onlydumpaccepts a second positional argument of a file-like object to write to.