Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in v1.1.0 #147

Conversation

thefirstofthe300
Copy link
Contributor

Don't create a resource in the core project factory module that pulls in the gsuite provider.

@thefirstofthe300 thefirstofthe300 force-pushed the seymourd/fix-gsuite-provider-regression branch from 91f3694 to ba4c4b8 Compare February 22, 2019 23:41
@thefirstofthe300 thefirstofthe300 marked this pull request as ready for review February 22, 2019 23:52
adrienthebo
adrienthebo previously approved these changes Feb 23, 2019
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in CI and against the repository that first manifested this bug, 👍.

@adrienthebo adrienthebo dismissed their stale review February 23, 2019 00:14

Dismissing review

@thefirstofthe300 thefirstofthe300 force-pushed the seymourd/fix-gsuite-provider-regression branch from ba4c4b8 to ac9ca17 Compare February 23, 2019 00:20
@thefirstofthe300 thefirstofthe300 force-pushed the seymourd/fix-gsuite-provider-regression branch from ac9ca17 to c557f9e Compare February 23, 2019 00:23
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally verified that the correct group is created, and CI has passed. 👍

@adrienthebo adrienthebo merged commit c182a16 into terraform-google-modules:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants