Stablize default service account in plan #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefirstofthe300
force-pushed
the
ds/stabilize-plan
branch
2 times, most recently
from
d899a3c
to
84235ea
Compare
adrienthebo
reviewed
Feb 28, 2019
The default service account data resource currently uses a depends_on flag added to prevent a race condition in terraform-google-modules#141 Due to the way that Terraform refreshes data resources, Terraform thinks that the data resource has changed when in actuality it hasn't: hashicorp/terraform#11806 (comment) By changing to use a null data resource that interpolates the default service account email, the data resource will only change when the project number does.
thefirstofthe300
force-pushed
the
ds/stabilize-plan
branch
from
84235ea
to
8f30fa9
Compare
thefirstofthe300
requested review from
aaron-lane and
morgante
as code owners
adrienthebo
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default service account data resource currently uses a depends_on
flag added to prevent a race condition in
#141
Due to the way that Terraform refreshes data resources, Terraform thinks
that the data resource has changed when in actuality it hasn't:
hashicorp/terraform#11806 (comment)
By changing to use a null data resource that interpolates the default
service account email, the data resource will only change when the project
number does.