Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_cluster: Remove plan-time validation for node_type and subnet_group_name #4333

Merged
merged 1 commit into from
Apr 25, 2018
Merged

resource/aws_elasticache_cluster: Remove plan-time validation for node_type and subnet_group_name #4333

merged 1 commit into from
Apr 25, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 24, 2018

Fixes #4120

This validation was incorrect in a few ways:

  • It did not properly handle computed values (e.g. ${aws_elasticache_subnet_group.X.id})
  • It prevented valid configurations (cache.t2.X nodes without subnet_group_name will automatically go into default subnet_group)

@bflad bflad added bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. labels Apr 24, 2018
@bflad bflad added this to the v1.16.0 milestone Apr 24, 2018
@bflad bflad requested a review from a team April 24, 2018 19:17
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 24, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 25, 2018

Self-merging for release today. 😉

@bflad bflad merged commit 1a76f22 into master Apr 25, 2018
@bflad bflad deleted the b-aws_elasticache_cluster-remove-node_type-validation branch April 25, 2018 14:59
@bflad bflad mentioned this pull request Apr 25, 2018
Closed
bflad added a commit that referenced this pull request Apr 25, 2018
@bflad
Update CHANGELOG for #4333
606771d
@bflad bflad mentioned this pull request Apr 26, 2018
Merged
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

[Elasticache cluster] Plan time node_type validation broken for new resources
1 participant
@bflad