Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on azurerm_media_streaming_endpoint when destroying a running instance #10216

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix error on azurerm_media_streaming_endpoint when destroying a running instance #10216

merged 2 commits into from
Jan 22, 2021

Conversation

jcanizalez
Copy link
Contributor

hello
This PR fixes #10156

@ghost ghost added the size/XS label Jan 17, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcanizalez

Thanks for this PR - whilst this PR looks good insofar as it'll stop the streaming endpoint prior to deletion, I'm wondering if we need to conditionally check this is started prior to running? Since this is fixing a bug during deletion it'd also be worth updating the tests to account for this case so we can verify this is fixed/doesn't regress in the future (I've commented with an example of how to do this).

Thanks!

@ghost ghost added size/S and removed size/XS labels Jan 21, 2021
@jcanizalez
Copy link
Contributor Author

Thanks @tombuildsstuff I applied status validation and also included test for scenario. I ran acc tests locally and it's working on both cases: stopped and running. So when you have time if you can give another review please.

@jcanizalez jcanizalez closed this Jan 21, 2021
@ghost ghost removed the waiting-response label Jan 21, 2021
@jcanizalez jcanizalez reopened this Jan 21, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @jcanizalez 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-01-22 at 10 20 50

@tombuildsstuff tombuildsstuff merged commit 85842b5 into hashicorp:master Jan 22, 2021
tombuildsstuff added a commit that referenced this pull request Jan 22, 2021
@jcanizalez jcanizalez deleted the fix_streaming_endpoint branch January 25, 2021 19:53
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error destroying running Streaming Endpoint
2 participants