-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error on azurerm_media_streaming_endpoint when destroying a running instance #10216
fix error on azurerm_media_streaming_endpoint when destroying a running instance #10216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jcanizalez
Thanks for this PR - whilst this PR looks good insofar as it'll stop the streaming endpoint prior to deletion, I'm wondering if we need to conditionally check this is started prior to running? Since this is fixing a bug during deletion it'd also be worth updating the tests to account for this case so we can verify this is fixed/doesn't regress in the future (I've commented with an example of how to do this).
Thanks!
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
Thanks @tombuildsstuff I applied status validation and also included test for scenario. I ran acc tests locally and it's working on both cases: stopped and running. So when you have time if you can give another review please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @jcanizalez 👍
This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.45.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
hello
This PR fixes #10156