-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_linux|windows_virtual_machine
- support platform_fault_domain
for VMSS Flex support
#10803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ArcturusZhang - Thanks for this PR.
I have concerns around the behaviour of this property. The validation suggests that -1
is not a valid value, but this is the default and the docs suggest the user can specify it (which they will not currently be able to). Can you please check which is correct and I'll continue review?
Thanks
Oh, sorry I missed that! I will change the validation to The logic in this attribute is like this: To support the Also when we are not setting the |
Hi @jackofallops I just updated the validation function, please take a look, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments inline but this otherwise LGTM 👍
Merging the suggestions so we can get this into this release |
dismissing since changes have been pushed
Tests look good 👍 |
This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.51.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.