Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public network access to container registry #10969

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Mar 15, 2021

To address issue #7334

Below paste the run pass result for th test cases

=== RUN   TestAccContainerRegistry_update
=== PAUSE TestAccContainerRegistry_update
=== CONT  TestAccContainerRegistry_update
--- PASS: TestAccContainerRegistry_update (213.56s)
PASS

=== RUN   TestAccContainerRegistry_networkAccessProfileIp
=== PAUSE TestAccContainerRegistry_networkAccessProfileIp
=== CONT  TestAccContainerRegistry_networkAccessProfileIp
--- PASS: TestAccContainerRegistry_networkAccessProfileIp (161.77s)
PASS

=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== CONT  TestAccContainerRegistry_geoReplication
--- PASS: TestAccContainerRegistry_geoReplication (856.19s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 👍

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a test failure, could we fix it to make sure its not from the api upgrade:

------- Stdout: -------
=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== CONT  TestAccContainerRegistry_geoReplication
    testing.go:620: Step 1/5 error: Check failed: Check 4/5 error: azurerm_container_registry.test: Attribute 'georeplication_locations.0' expected "westeurope", got "eastus2"
--- FAIL: TestAccContainerRegistry_geoReplication (214.52s)
FAIL

------- Stderr: -------
2021/03/17 23:57:52 [DEBUG] not using binary driver name, it's no longer needed
2021/03/17 23:57:52 [DEBUG] not using binary driver name, it's no longer needed

@katbyte katbyte added this to the v2.53.0 milestone Mar 18, 2021
@ms-henglu
Copy link
Contributor Author

@katbyte Thanks for code review. I added a commit to fix the test. By the way, the test fails before API upgrade. Please review again. Thanks!

@ms-henglu ms-henglu requested a review from katbyte March 19, 2021 08:11
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 👍

@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.53.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2021
@ms-henglu ms-henglu deleted the ticket-1823982-add-public-network-access-to-container-registry branch May 6, 2021 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants