Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMSS: changed sku property from a set to list #1558

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 12, 2018

Yet another set -> list change.

Helps with #930 by allowed the capacity property to easily be ignored.

@katbyte katbyte added bug service/vmss Virtual Machine Scale Sets labels Jul 12, 2018
@katbyte katbyte added this to the 1.10.0 milestone Jul 12, 2018
@katbyte katbyte requested review from tombuildsstuff and a team July 12, 2018 19:25
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit ba9e3f5 into master Jul 13, 2018
@katbyte katbyte deleted the b-vmss-skuset branch July 13, 2018 17:10
katbyte added a commit that referenced this pull request Jul 16, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/vmss Virtual Machine Scale Sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants