Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_firewall_nat_rule_collection #3218

Merged
merged 5 commits into from
Apr 29, 2019

Conversation

Lucretius
Copy link
Contributor

This resolves #2224 by adding a firewall_nat_rule_collection resource. This code is mostly copied from the firewall_network_rule_collection with some additions made for the additional properties required by the NAT rule.

As I have never used this resource, my research led me to the following:

  1. In the Azure Portal I could not find a way to create a NAT rule collection using Snat, even though it is an option in the Go SDK.
  2. UDP and TCP are the only allowed protocols for Dnat, not sure about Snat but my assumption is that it can include ICMP (probably to receive/responding to a ping which uses the ICMP protocol)
  3. For Dnat - every property included translated_address and translated_port are required. I am not sure about Snat as I can find minimal information on it's Azure implementation.

If anyone has more familiarity with this resource who can sanity check my research, I would be happy for it.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Lucretius

@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 16, 2019
@tombuildsstuff tombuildsstuff changed the title Nat rule collection New Resource: azurerm_firewall_nat_rule_collection Apr 16, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.25.0, v1.26.0 Apr 16, 2019
@katbyte katbyte modified the milestones: v1.26.0, v1.27.0 Apr 17, 2019
@katbyte katbyte merged commit 44c395c into hashicorp:master Apr 29, 2019
katbyte added a commit that referenced this pull request Apr 29, 2019
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_firewall: No option to create NAT rule collections and NAT rules
3 participants