Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_traffic_manager_profile - support for custom_header (#2187) #5923

Merged
merged 13 commits into from
Mar 21, 2020

Conversation

jstevans
Copy link
Contributor

@jstevans jstevans commented Feb 26, 2020

(fixes #2187)

@ghost ghost added the size/S label Feb 26, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstevans,

Thanks for the PR, in addtion to the comments i've left inline could we add set this in the complete test to make sure it works and update the docs to reflect the new property? thanks!

@ghost ghost added size/M and removed size/S labels Mar 3, 2020
@jstevans jstevans requested a review from katbyte March 3, 2020 00:16
@ghost ghost added the documentation label Mar 3, 2020
@jstevans
Copy link
Contributor Author

jstevans commented Mar 18, 2020

@katbyte I've responded to your concerns -- would be great to get another look 🙂

Also, due to covid19 I'm unable to get to the computer that has a working terraform-provider-azurerm repo, and I can't manually figure out what's wrong with the formatting of this code. The tflint job is failing, could I ask you to please run terrafmt for me?

@ghost ghost removed the waiting-response label Mar 18, 2020
@katbyte katbyte added this to the v2.3.0 milestone Mar 21, 2020
@katbyte katbyte changed the title Add custom_header param to TrafficManager profiles (#2187) azurerm_traffic_manager_profile - support for custom_header (#2187) Mar 21, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jstevans,

I've made the required changes and this LGTM now 👍 stay safe

@jstevans
Copy link
Contributor Author

@katbyte You rock! 🙌 How do we go about getting this merged?

@katbyte katbyte merged commit 86565f1 into hashicorp:master Mar 21, 2020
katbyte added a commit that referenced this pull request Mar 21, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Custom Header Settings" field for Traffic Manager Endpoint
2 participants