Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_managed_disk.disk_encryption_set_id without recreating the resource #6207

Merged
merged 3 commits into from
Mar 23, 2020

Conversation

kazimierzbudzyk
Copy link
Contributor

Fixes: #6184

CMK encryption can be enabled without recreating (requires VM to be stopped): https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disk-encryption#enable-on-an-existing-disk

@ghost ghost added the size/XS label Mar 21, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kazimierzbudzyk,

thanks for the PR, could we add a test that changes the encryption id & update the docs? thanks!

@kazimierzbudzyk
Copy link
Contributor Author

Thank you for the review @katbyte! Applied requested changes, let me know if you have any other comments!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @kazimierzbudzyk

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review March 23, 2020 10:02

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 23, 2020
@tombuildsstuff tombuildsstuff merged commit 4dafe5b into hashicorp:master Mar 23, 2020
@tombuildsstuff
Copy link
Contributor

(Tests look fine)

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed disk encryption set changes force resource recreation
3 participants