Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-azure-helpers to v0.7.0, go-autorest to v13.0.0 and azure-dk-for-go to `v32. #103

Merged
merged 5 commits into from
Aug 27, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 21, 2019

No description provided.

@katbyte katbyte changed the title update go-azure-helpers to v0.7.0 Update go-azure-helpers to v0.7.0, go-autorest to v13.0.0 and azure-dk-for-go to `v32. Aug 21, 2019
@katbyte katbyte requested a review from a team August 24, 2019 19:34
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

github.com/Azure/azure-sdk-for-go v30.0.0+incompatible
github.com/Azure/go-autorest v11.7.0+incompatible
github.com/Azure/azure-sdk-for-go v32.5.0+incompatible
github.com/Azure/go-autorest v13.0.0+incompatible // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we run GO111MODULE=on go mod tidy I think this should disappear

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but because of autorests weird and crazy versioning it has to be there so go modules doesn't get super confused i believe

@katbyte katbyte added this to the v0.9.0 milestone Aug 27, 2019
@katbyte katbyte merged commit 23b4d42 into master Aug 27, 2019
@katbyte katbyte deleted the d/helpers-7 branch August 27, 2019 18:57
katbyte added a commit that referenced this pull request Aug 27, 2019
@ghost
Copy link

ghost commented Aug 30, 2019

This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurestack" {
    version = "~> 0.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants