[feature] CHANGING set response_time_ns as the sum of time spent in e…

…sxcli cmds per poll instead of the running mean

internal/vccollector/cache.go

@@ -269,6 +269,15 @@ func (c *VcCollector) GetNumberNotRespondingHosts() int {
 	return numnotresponding
 }
 
+// ResetResponseTimes set host states response times to 0
+func (c *VcCollector) ResetResponseTimes() {
+	for i := range c.dcs {
+		for _, hState := range c.hostStates[i] {
+			hState.responseTime = 0
+		}
+	}
+}
+
 func (c *hostState) setNotConnected(conn bool) {
 	c.notConnected = conn
 }
@@ -288,6 +297,10 @@ func (c *hostState) setMeanResponseTime(dur time.Duration) {
 	}
 }
 
+func (c *hostState) sumResponseTime(dur time.Duration) {
+	c.responseTime += dur
+}
+
 func (c *hostState) isHostConnectedAndResponding(skipDuration time.Duration) bool {
 	var connectedResponding bool
 

internal/vccollector/host.go

@@ -160,7 +160,7 @@ func (c *VcCollector) CollectHostHBA(
 				continue
 			}
 			res, err = x.Run([]string{"storage", "core", "adapter", "list"})
-			hostSt.setMeanResponseTime(time.Since(startTime))
+			hostSt.sumResponseTime(time.Since(startTime))
 			if err != nil {
 				hostExecutorRunAddError(acc, "storage core", host.Name(), err)
 				hostSt.setNotResponding(true)
@@ -236,7 +236,7 @@ func (c *VcCollector) CollectHostNIC(
 				continue
 			}
 			res, err = x.Run([]string{"network", "nic", "list"})
-			hostSt.setMeanResponseTime(time.Since(startTime))
+			hostSt.sumResponseTime(time.Since(startTime))
 			if err != nil {
 				hostExecutorRunAddError(acc, "network nic", host.Name(), err)
 				hostSt.setNotResponding(true)
@@ -316,7 +316,7 @@ func (c *VcCollector) CollectHostFw(
 				continue
 			}
 			res, err = x.Run([]string{"network", "firewall", "get"})
-			hostSt.setMeanResponseTime(time.Since(startTime))
+			hostSt.sumResponseTime(time.Since(startTime))
 			if err != nil {
 				hostExecutorRunAddError(acc, "network firewall", host.Name(), err)
 				hostSt.setNotResponding(true)

plugins/inputs/vcstat/vcstat.go

@@ -8,6 +8,7 @@ package vcstat
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/url"
 	"time"
@@ -121,6 +122,8 @@ var sampleConfig = `
   # vm_instances = false
 `
 
+var ErrorNoCollector = errors.New("collector not yet created")
+
 func init() {
 	inputs.Add("vcstat", func() telegraf.Input {
 		return &Config{
@@ -343,7 +346,9 @@ func (vcs *Config) gatherHighLevelEntities(
 		err error
 	)
 
-	col = vcs.vcc
+	if col = vcs.vcc; col == nil {
+		return ErrorNoCollector
+	}
 
 	//--- Get vCenter basic stats
 	if err = col.CollectVcenterInfo(ctx, acc); err != nil {
@@ -378,7 +383,10 @@ func (vcs *Config) gatherHost(
 		err                 error
 	)
 
-	col = vcs.vcc
+	if col = vcs.vcc; col == nil {
+		return ErrorNoCollector
+	}
+
 	if vcs.HostInstances {
 		if err = col.CollectHostInfo(ctx, acc); err != nil {
 			return err
@@ -387,6 +395,7 @@ func (vcs *Config) gatherHost(
 
 	if vcs.HostHBAInstances {
 		hasEsxcliCollection = true
+		col.ResetResponseTimes()
 		if err = col.CollectHostHBA(ctx, acc); err != nil {
 			return err
 		}
@@ -438,7 +447,10 @@ func (vcs *Config) gatherNetwork(
 		err error
 	)
 
-	col = vcs.vcc
+	if col = vcs.vcc; col == nil {
+		return ErrorNoCollector
+	}
+
 	if vcs.NetDVSInstances {
 		if err = col.CollectNetDVS(ctx, acc); err != nil {
 			return err
@@ -462,9 +474,8 @@ func (vcs *Config) gatherStorage(
 	if vcs.DatastoreInstances {
 		var col *vccollector.VcCollector
 		var err error
-		col = vcs.vcc
-		if col == nil {
-			return nil
+		if col = vcs.vcc; col == nil {
+			return ErrorNoCollector
 		}
 		if err = col.CollectDatastoresInfo(ctx, acc); err != nil {
 			return tgplus.GatherError(acc, err)
@@ -482,9 +493,8 @@ func (vcs *Config) gatherVM(
 	if vcs.VMInstances {
 		var col *vccollector.VcCollector
 		var err error
-		col = vcs.vcc
-		if col == nil {
-			return nil
+		if col = vcs.vcc; col == nil {
+			return ErrorNoCollector
 		}
 		if err = col.CollectVmsInfo(ctx, acc); err != nil {
 			return tgplus.GatherError(acc, err)