-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect helm repo name #26
fix incorrect helm repo name #26
Conversation
@@ -12,7 +12,7 @@ _See [helm repo](https://helm.sh/docs/helm/helm_repo/) for command documentation | |||
To install the chart with the release name `fleet-telemetry`: | |||
|
|||
```console | |||
helm install fleet-telemetry charts/fleet-telemetry -n fleet-telemetry | |||
helm install fleet-telemetry teslamotors/fleet-telemetry -n fleet-telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this change is not correct as we are talking about https://github.com/teslamotors/helm-charts/tree/main/charts/fleet-telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is actually correct because the first step in the README is adding this chart repo locally with the name teslamotors
. The install command then references the repo name and the chart name. So the install command in the README does not work because the repo name referenced is charts
but the repo was added with name teslamotors
.
This PR is actually because the instructions did not work for me locally (Helm version 3.12.1), but it did work after changing the repo name from charts
to teslamotors
in the helm repo add
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
@@ -12,7 +12,7 @@ _See [helm repo](https://helm.sh/docs/helm/helm_repo/) for command documentation | |||
To install the chart with the release name `fleet-telemetry`: | |||
|
|||
```console | |||
helm install fleet-telemetry charts/fleet-telemetry -n fleet-telemetry | |||
helm install fleet-telemetry teslamotors/fleet-telemetry -n fleet-telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Force merge to ignore version bump |
I noticed that in the README.md the helm install commands had a wrong repo name (
charts
instead ofteslamotors
). This PR fixes the incorrect name.