Gcode issue1199 p2 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. memry removal. This should be no-brainer. These functions never seemed to do anything useful. The only oddity was with alloc_string which rounded the allocation upwards to nearest multiple of 4. Based on my review of code, I could not identify any value in this feature, so even alloc_string was simply transformed to malloc. memry.* are removed. All code is adjusted to simply call malloc and free instead. listio.* are removed. The list reading function in these files appears to have been unused, and contained the only invocation of strsave define, which was one of the alloc_string users, so I removed both of them. https://code.google.com/p/tesseract-ocr/issues/detail?id=1199
…. memry and emalloc removal.
2. memry and emalloc removal.
As above, but also removes emalloc* and replaces all uses of E{malloc,realloc,free} with the standard versions.
This is somewhat more controversial, because the E variants bothered to check the return value from the respective function, and would perform DoError if it determined it to have failed, which terminates in message to console and err_exit(). This is arguably nicer than crashing on null pointer value, but large parts of the code have never cared about malloc's potential NULL values, so I'd say it doesn't really help that parts of it now do.
Perhaps the real plan for moving forwards is to also replace malloc/free, and instead start using new/delete operators, and allow them to throw exceptions if the object construction fails due to memory allocation error. In this sense, the second patch may be considered as a stepping stone on the path towards such future version of Tesseract.
Conflicts:
classify/flexfx.cpp
|
Internet Archive copy of discussion in original issue: https://web.archive.org/web/20151128081631/http://code.google.com/p/tesseract-ocr/issues/detail?id=1199 |
|
I think this one can be safely closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split commits; builds on -p1, so includes that patch. Updated to current version