Fix libdir in tesseract.pc from CMake #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesseract.pc.cmake was hardcoding libdir to
`{prefix}/lib`, which is wrong for systems that use
`/usr/lib64/` on 64-bit. `CMAKE_INSTALL_LIBDIR`
is already expected to contain the libdir path
relative to the install prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tesseract.pc.cmakewas hardcoding libdir to${prefix}/lib, which is wrong for systems that place 64-bit libraries in/usr/lib64/.On Fedora, this was causing a CMake-generated
tesseract.pc, installed to/usr/lib64/pkgconfig/, to produce library flags that included-L/usr/lib, potentially polluting 64-bit builds with 32-bit libs.CMAKE_INSTALL_LIBDIRis already expected to contain the arch-corrected libdir path relative to the CMake install prefix, so it can be used to set the pkg-configlibdirrelative to${prefix}.