Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build without git clone in cloned directory #4099

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Jul 11, 2023

FreeBSD uses git to manage Ports Tree. Tesseract, when building from the Ports Tree, is built from a tarball that doesn't have .git and then git describe is ran on top of the Ports Tree.

FreeBSD uses git to manage Ports Tree. Tesseract, when building from the Ports Tree, is built from a tarball that doesn't have .git and then git describe is ran on top of the Ports Tree.
@stweil
Copy link
Contributor

stweil commented Jul 11, 2023

So the whole Tesseract source tree is a subdirectory of some directoy structure which is managed with Git? Will your patch also work when configure is running out-of-tree?

@pkubaj
Copy link
Contributor Author

pkubaj commented Jul 11, 2023

Indeed it is in a subdirectory managed by git. Running configure out of tree probably won't work, but I don't think anyone does that (I certainly have never done that).

@stweil
Copy link
Contributor

stweil commented Jul 11, 2023

I nearly never run builds in-tree, but usually have a build directory somewhere below the source root, so git describe works fine. Supporting out-of-tree builds is important in my opinion

Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I tested the commit. It also works fine with out-of-tree builds.

@stweil stweil merged commit 82c7999 into tesseract-ocr:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants