-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Diplopia Solution #4211
base: main
Are you sure you want to change the base?
Conversation
I don't see a commit which changes the Tesseract code. Is something missing? |
OK thanks @stweil This may leave you somewhat concerned about my code changes, but I can assure you that I am a competent developer. I just never use GitHub other than with Tesseract, hence incompetent in that regard. Note by the way, similar to the other pull request I generated, there are some new configuration values that can only be set in code as it stands, but should be made into available settings. I have not yet figured out the mechanism for doing that. If the diplopia changes I am proposing turn out to be useful, hopefully someone else familiar with the settings approach could take care of that. These configuration values are:
|
Apart from testing that this patch has a positive effect on the diplopia issue, people should test if there is no negative effect in other places, like dropping of correct characters. |
Please note that this change is likely not appropriate for those using Tesseract for natural language recognition using relevant dawgs. It is primarily intended for those (like myself) using Tesseract to scan technical data, looking for exact character by character recognition. |
Hi, |
This PR adds 425 lines to the neural network's code. According to the PR author, his solution to the 'diplopia' issue is not a generic solution. It tries to solve a specific use case. So the question is, is it worth it? Do we want this in Tesseract? Another question, is this Engilsh only solution? Will it work well with all other Latin based languages? What about other scripts like Cyrillic, Indic scripts, Hangul (Korrean), Chinese and Japanese scripts? If we decide we do want this solution, the code still lacks a config variable. It should be boolean, set to 'False' by default. |
We know that better models reduce the number of diplopia cases. That should work for all languages and scripts and is my preferred solution for the problem, instead of very special solutions in the software with unknown side effects. |
Hi all: Just a few comments from myself, the author of this diplopia fix:
For my own purposes, I don't need this fix incorporated into the main Tesseract code, as I am quite happy running my own custom copy. However, I have taken the time to promote it in this pull request to try to make a modest but hopefully meaningful contribution to Tesseract. If it is not going to see the light of day for others, that is unfortunate. Regards, Dave |
I previously created a pull request from my branch JDWDIPLOPIA. This solution, while better than without it as far as diplopia is concerned, was a limited solution.
I am now creating a pull request from my branch JDWDIPLOPIA2. I believe that this is a more complete solution to the diplopia issue.