Buffer errors until the end of an action #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I just tested this and tweaked one of the suiles to have a syntax error. With this PR, all instances complete. I also ran the same suites with the currently released 1.8.0 but the results were basically the same. Unfortunately the nature of the thread related bugs are tough to reproduce consistently. Based on the code changes here, I do think this will be more reliable and certainly won't make things less reliable. |
|
I tested this by tweaking a provisioner to raise an unhandled error and validating that, with varying levels of concurrency specified, it would work its way through all the specified suites, rather than dying at the first unhandled error. All the errors would be rolled up and available with stack traces in the log. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the behavior where an earlier failure would block later instances. With this PR, all the errors for the action are buffered until the end of the action for all instances. If there were any errors, they are reported (one in the console - the rest in the log).