Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] beta version and management sdk #3201

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

JackTn
Copy link

@JackTn JackTn commented Feb 2, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

raych1 and others added 30 commits September 13, 2023 06:39
* Rename bug.md to bug_report.md

* Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
@JackTn JackTn closed this Feb 2, 2024
@JackTn JackTn deleted the jacktn/test-beta-resourcemanager branch February 2, 2024 08:06
@JackTn JackTn restored the jacktn/test-beta-resourcemanager branch February 2, 2024 08:20
@JackTn JackTn reopened this Feb 2, 2024
@JackTn
Copy link
Author

JackTn commented Feb 5, 2024

/azp run

Copy link

openapi-pipeline-app-test bot commented Feb 5, 2024

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has at least one breaking change from a previous GA version (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app-test bot commented Feb 5, 2024

Swagger Generation Artifacts

️🔄~[NotRequired_Staging] ApiDocPreview inProgress [Detail]
️❌ azure-sdk-for-python-track2 failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
    Validation Failed: {"message":"Only the pull request author may change the maintainer_can_modify value","resource":"PullRequest","field":"maintainer_can_modify","code":"invalid"}
  • ️✔️track2_azure-mgmt-cosmosdb [View full logs
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.CosmosDB [View full logs]  [Preview SDK Changes]
️🔄 azure-sdk-for-java inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/cosmos/armcosmos [View full logs]  [Preview SDK Changes] Breaking Change Detected
️❌ azure-sdk-for-js failed [Detail]
  • Failed [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] ERROR: The command failed with exit code 1
    cmderr	[automation_generate.sh] [ERROR] Error:
    cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for readme file: "specification/cosmos-db/resource-manager/readme.md":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush update
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush update
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:85:33)
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
    cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
  • @azure/arm-cosmosdb [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️cosmos-db [View full logs]  [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 07a2f2d4bb97afc059df056644e72cf2c7acd9ac. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.cosmos-db.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Feb 5, 2024

Copy link

openapi-pipeline-app-test bot commented Feb 5, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 18 Errors, 2 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
cosmos-db.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
cosmos-db.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
dataTransferService.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
managedCassandra.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
managedCassandra.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
mongoCluster.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
mongorbac.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
mongorbac.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
notebook.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
notebook.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
privateEndpointConnection.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
privateEndpointConnection.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
privateLinkResources.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
privateLinkResources.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
rbac.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
rbac.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
restorable.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
restorable.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
services.json 2024-01-15-preview(252ac0b) 2023-11-15(main)
services.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)
throughputpool.json 2024-01-15-preview(252ac0b) 2023-11-15-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L1534:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L1202:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L49:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L49:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L85:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L85:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L121:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L121:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L159:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L159:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L197:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L197:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L250:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L250:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L305:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L305:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L586:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L356:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L625:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L395:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L666:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L436:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L707:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L477:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L763:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L533:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L821:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L591:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L861:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L628:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L897:9
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L664:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L632:5
Old: common-types/resource-management/v2/types.json#L649:5
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'readwrite' renamed or removed?
New: Microsoft.DocumentDB/preview/2024-01-15-preview/managedCassandra.json#L1529:7
Old: Microsoft.DocumentDB/stable/2023-11-15/managedCassandra.json#L1197:7
⚠️ 1014 - RemovingHeader The new version removs a required header 'azure-AsyncOperation'.
Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L140:15
⚠️ 1014 - RemovingHeader The new version removs a required header 'location'.
Old: Microsoft.DocumentDB/stable/2023-11-15/services.json#L144:15
️🔄LintDiff inProgress [Detail]
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule Message
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/cosmos-db/resource-manager/readme.md
json: preview/2024-01-15-preview/examples/CosmosDBManagedCassandraCommandResultList.json
⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
readme: specification/cosmos-db/resource-manager/readme.md
json: Microsoft.DocumentDB/preview/2024-01-15-preview/privateEndpointConnection.json
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Copy link

Hi @JackTn! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants