Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer image #2531

Merged
merged 3 commits into from
May 6, 2024

Conversation

bells17
Copy link
Contributor

@bells17 bells17 commented May 5, 2024

What does this PR do?

Update the devcontainer image to the following image: mcr.microsoft.com/devcontainers/go:1.22-bookworm.

Why is it important?

Currently, we cannot open the project using devcontainer because the devcontainer image mcr.microsoft.com/devcontainers/go:0-1.21-bullseye cannot be found.

Related issues

@bells17 bells17 requested a review from a team as a code owner May 5, 2024 15:12
Copy link

netlify bot commented May 5, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit fb5274f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6638c88f2f482c00081d789a
😎 Deploy Preview https://deploy-preview-2531--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the changes! Could you take a look at the Go version 🙏 ?

Cheers

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@bells17 bells17 requested a review from mdelapenya May 6, 2024 08:27
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya
Copy link
Member

The influx error is not related: it will be fixed with #2532

@mdelapenya mdelapenya self-assigned this May 6, 2024
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality dependencies Dependencies or external services and removed chore Changes that do not impact the existing functionality labels May 6, 2024
@mdelapenya mdelapenya merged commit 5c5ff44 into testcontainers:main May 6, 2024
104 checks passed
@bells17 bells17 deleted the update-devcontainer-image branch May 7, 2024 01:17
mdelapenya added a commit to khartld/testcontainers-go that referenced this pull request May 7, 2024
* main: (44 commits)
  feat: expose JSON representation of a container with Inspect (testcontainers#2534)
  chore(deps): bump test-summary action to v2.3 (testcontainers#2535)
  chore(deps): bump jinja2 from 3.1.3 to 3.1.4 (testcontainers#2533)
  Update devcontainer image (testcontainers#2531)
  chore(influxdb): include more characters in wait for log regex (testcontainers#2532)
  fix(compose): avoid race conditions when caching services (testcontainers#2528)
  chore(deps): bump golangci/golangci-lint-action from 3.7.0 to 5.1.0 (testcontainers#2525)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.1.21 (testcontainers#2524)
  chore(compose): return error in options (testcontainers#2520)
  chore(deps): bump github.com/compose-spec/compose-go/v2 from v2.0.0-rc8 to v2.1.0 (testcontainers#2519)
  chore(deps): bump github.com/containerd/containerd from 1.7.12 to 1.7.15 (testcontainers#2517)
  break: return error from Customize request option (testcontainers#2267)
  fix: wrong copy paste (testcontainers#2515)
  docs: add documentation for Exec method (testcontainers#2451)
  docs: document the SSHd tunnel (testcontainers#2514)
  fix: enhance host configuration port binding (testcontainers#2512)
  feat: forward host ports to a container using an SSH tunnel (testcontainers#2471)
  Update follow_logs.md with adding missing package (testcontainers#2513)
  fix: don't retry on permanent APIClient errors (testcontainers#2506)
  feat: support overriding the default recreate options for compose (testcontainers#2511)
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 22, 2024
mdelapenya added a commit that referenced this pull request Aug 23, 2024
* fix: update devcontainer image

Caused by #2531

* chore: bump minimal Go version to 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants