Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with maven-enforcer-plugin and testcontainers 1.7.0 #652

Closed
farodin91 opened this issue Apr 23, 2018 · 8 comments
Closed

Problems with maven-enforcer-plugin and testcontainers 1.7.0 #652

farodin91 opened this issue Apr 23, 2018 · 8 comments

Comments

@farodin91
Copy link

I'm trying to integrate testcontainers into janusgraph. The build process checks the dependencies and maven-enforcer-plugin shows this error:

Dependency convergence error for org.jetbrains:annotations:15.0 paths to dependency are:
+-org.janusgraph:janusgraph-cassandra:0.3.0-SNAPSHOT
  +-org.testcontainers:testcontainers:1.7.0
    +-org.jetbrains:annotations:15.0
and
+-org.janusgraph:janusgraph-cassandra:0.3.0-SNAPSHOT
  +-org.testcontainers:testcontainers:1.7.0
    +-org.rnorth.duct-tape:duct-tape:1.0.6
      +-org.jetbrains:annotations:13.0

It would be cool to check the dependency consistency.

@bsideup bsideup added this to the next milestone Apr 23, 2018
@bsideup
Copy link
Member

bsideup commented Apr 23, 2018

Hi @farodin91,

Good to see janusgraph experimenting with Testcontainers 👍

Thanks for letting us know! In addition to fixing it, I'll check if there are some enforcer-like plugins for Gradle to automate the check on our side.

FYI 1.7.1 was released on Friday with a bunch of fixes and it's recommended to update :)

@farodin91
Copy link
Author

I updated the version but it doesn't fix the problem.

@bsideup
Copy link
Member

bsideup commented Apr 30, 2018

Hi @farodin91,
we released 1.7.2 today where the problem is fixed, please try :)

@arnzel
Copy link
Contributor

arnzel commented Jun 7, 2018

I get the error also in 1.7.3:

Dependency convergence error for org.jetbrains:annotations:15.0 paths to dependency are:
+-...
+-...
+-org.testcontainers:testcontainers:1.7.3
+-org.jetbrains:annotations:15.0
and

+...
+..
+-org.testcontainers:testcontainers:1.7.3
+-org.rnorth.duct-tape:duct-tape:1.0.7
+-org.jetbrains:annotations:13.0

@arnzel
Copy link
Contributor

arnzel commented Jun 7, 2018

Same error in 1.7.2

@kiview
Copy link
Member

kiview commented Jun 12, 2018

@farodin91 Do you also see the errors observed by @arnzel in your use case?
I'll reopen the issue.

@farodin91
Copy link
Author

Seem to fail with the same issue by me.

@rnorth
Copy link
Member

rnorth commented Jul 12, 2018

#772, which should fix this, was released in 1.8.1. Please could you check again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants