Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useUnicode & characterEncoding parameters are ignored for TC_INITSCRIPT #727

Closed
dmart28 opened this issue Jun 1, 2018 · 3 comments
Closed

Comments

@dmart28
Copy link
Contributor

dmart28 commented Jun 1, 2018

Hi!

We've noticed that starting from 1.7.0+ releases the useUnicode and characterEncoding JDBC params in the JDBC URL are being ignored while executing TC_INITSCRIPT. Probably, other params are being ignored as well. As a result, if we have some, for example, russian symbols in the init SQL file, they are passed to the MySQL as a '?' signs, while on the 1.6.0 version it's not the case. Can you suggest what's the problem, is it a bug indeed?

Thanks!

@rnorth
Copy link
Member

rnorth commented Jun 10, 2018

Hi @dmart28 - thanks for reporting and for the PR, and sorry for taking time to follow up. I wonder if this might be resolved by the much bigger refactoring within #617.

In any case, please could you show us a failing test that we could use to check?

@dmart28
Copy link
Contributor Author

dmart28 commented Jun 13, 2018

Hi @rnorth - I've added a test to my PR which will fail without such fix. I've also checked #617 code and it doesn't seem to me that this issue is resolved here.

rnorth pushed a commit that referenced this issue Jul 10, 2018
@rnorth
Copy link
Member

rnorth commented Jul 12, 2018

Released in 1.8.1! 🎉

Thanks for your work to fix this @dmart28.

@rnorth rnorth closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants