Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects depreciated method getIpAddress in the docs #300

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

peter-evans
Copy link
Contributor

The method getIpAddress() is depreciated in favour of getContainerIpAddress(). This commit corrects the documentation to the latter.

@bsideup bsideup added this to the 1.1.10 milestone Mar 1, 2017
@bsideup bsideup merged commit b1e1395 into testcontainers:master Mar 1, 2017
@bsideup
Copy link
Member

bsideup commented Mar 1, 2017

Merged, thanks!

rnorth added a commit that referenced this pull request Mar 12, 2017
## [1.2.0] - 2017-03-12
### Fixed
- Fix various escaping issues that may arise when paths contain spaces (#263, #279)
- General documentation fixes/improvements (#300, #303, #304)
- Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295)

### Changed
- Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306)
- Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301)
- Shade `org.newsclub` and Guava dependencies (#299, #292)
- Add `org.testcontainers` label to all containers created by Testcontainers (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants