Remove MariaDB from modules and extract to separate repo
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whops, sorry for overriding your authorship, I thought Github would keep it. Thought it was good idea to squash the last two commits, since one of them updated the mariadb dependencies in the |
|
Ha, no problem, don't worry about it. I was planning to squash before merge, so 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #337. I've had a general desire to extract some modules out into their own repos for a while, and with MariaDB apparently facing some issues right now, this is impeding ability to release the project as a whole.
The MariaDB module is now at https://github.com/testcontainers/testcontainers-java-module-mariadb