Make sure the Docker Host IP address is retrieved correctly when running inside docker #541
Conversation
…ait the completion of one-off command
| .toString(); | ||
| LogToStringContainerCallback loggingCallback = new LogToStringContainerCallback(); | ||
| client.logContainerCmd(id).withStdOut(true) | ||
| .withStdErr(true) |
There was a problem hiding this comment.
I think withStdErr is not needed here
| client.logContainerCmd(id).withStdOut(true) | ||
| .withStdErr(true) | ||
| .withFollowStream(true) | ||
| .withTailAll() |
There was a problem hiding this comment.
tail=all is the default, can also remove it
|
@bsideup I'm afraid this fix won't help with the flaky log behavior regarding Or did you have another idea? |
|
@kiview this PR is not about LogMessageWaitStrategy's issue seems to be related to some race conditions |
|
Yes I know, I was referring to the discussion in #479 (comment), maybe I mixed this up 😉 |
There was a problem hiding this comment.
Hi @bsideup. I updated the code related to your remarks. Can you approve/comment the new commits? Jochen
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. | |||
| ### Fixed | |||
| - Fixed problem with case-sensitivity when checking internal port. ([\#524](https://github.com/testcontainers/testcontainers-java/pull/524)) | |||
| - Add retry logic around checkExposedPort pre-flight check for improved robustness ([\#513](https://github.com/testcontainers/testcontainers-java/issues/513)) | |||
| - Fixed retrieval of Docker host IP when running inside Docker. ([\#479](https://github.com/testcontainers/testcontainers-java/issues/479)) | |||
There was a problem hiding this comment.
This should go to the "upcoming" section, I will create one :)
There was a problem hiding this comment.
Urgh ... sorry, my mistake. Sorry, was doing things too fast. Thanks for taking this one on you.
|
@jochenhebbrecht merged, thanks! 👍 💪 |
jochenhebbrecht
deleted the
hotfix/docker-host-ip-not-retrieved-when-in-docker-container
branch
More details can be found here: #479 (comment)